upgrade test modules, fix tests #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Jun 12, 2020
| // isArray(opts.query) ? mfr(opts.query) : pull.through(), | ||
| // opts.limit && pull.take(opts.limit) | ||
| // ) | ||
| // } |
mixmix
commented
Jun 12, 2020
mixmix
commented
Jun 12, 2020
| .use('query', Query(1, {indexes: indexes})) | ||
| var log = FlumeLog( | ||
| path.join(dbPath, 'log.offset'), | ||
| { blockSize: 1024, codec: codec.json } |
There was a problem hiding this comment.
flumelog now has an opts arg we have to us
|
Hmmm .. Node 14 causing Travis trouble. Not sure why, cannot reproduce locally |
|
It's Linux would you believe.
Also God damn that glob hack
…On Sun, 14 Jun 2020, 09:54 Christian Bundy, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#18 (comment)>
:
> @@ -7,27 +7,30 @@
"type": "git",
"url": "git://github.com/flumedb/flumeview-query.git"
},
+ "scripts": {
+ "test": "tape test/*.js",
If this is still failing on Windows, try using single-quotes!
⬇️ Suggested change
- "test": "tape test/*.js",
+ "test": "tape 'test/*.js'",
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUK3HWMR6AS2B57KMFAMDDRWPYQRANCNFSM4N3K53DA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I versioned 8.0.0 without upgrading the test deps which would be the ideal check of whether this is working (sorry, my bad).
This branch is about: