Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race condition during git global variable setting #56

Open
tsalo opened this issue Jul 29, 2020 · 2 comments
Open

Possible race condition during git global variable setting #56

tsalo opened this issue Jul 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@tsalo
Copy link
Member

tsalo commented Jul 29, 2020

The home's gitconfig file "already exists" when it's being locked by jobs submitted at exactly the same time.

@tsalo tsalo added the bug Something isn't working label Jul 29, 2020
@tsalo
Copy link
Member Author

tsalo commented Jul 29, 2020

Since this happens at the very beginning of the workflow, if we just figure out how to delay the start of the workflows relative to when the jobs move out of the queue, it should be fine.

@akimbler
Copy link
Member

akimbler commented Sep 3, 2020

This has always been an issue in run() IMO, we should be using Popen.wait() to prevent processes from potentially starting before the previous process is finished, similar to the first comment in https://stackoverflow.com/questions/4417546/constantly-print-subprocess-output-while-process-is-running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants