Accommodate increased robustness in RPM 4.20 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPM prior to version 4.20 failed to parse some abridged spec files. Newer versions are more robust, so the fall back path won’t be used. Signed-off-by: Nils Philippsen <[email protected]>
|
Should we be dropping this? Fedora 39 and 40 both have older versions of RPM and are still actively maintained. Same for several other RPM-based distributions... |
|
@sgallagher Sorry for the late reply, didn’t notice your comment before I went on PTO…
Ahh I realize how this change can be confusing – the original conditional |
nphilipp
added a commit
to nphilipp/rpmautospec
that referenced
this pull request
Oct 10, 2024
The way it was done previously was too cute by half, looping over the abridged and unabridged spec file paths + conditionals galore, which confused coverage statistics. Also to the same end, make parsing the abridged spec file fail in relevant tests and don’t rely on rpm (>= 4.20) to do it (see fedora-infra#182). Signed-off-by: Nils Philippsen <[email protected]>
nphilipp
added a commit
to nphilipp/rpmautospec
that referenced
this pull request
Oct 10, 2024
The way it was done previously was too cute by half, looping over the abridged and unabridged spec file paths + conditionals galore, which confused coverage statistics. Also to the same end, make parsing the abridged spec file fail in relevant tests and don’t rely on rpm (>= 4.20) to do it (see fedora-infra#182). Signed-off-by: Nils Philippsen <[email protected]>
nphilipp
added a commit
to nphilipp/rpmautospec
that referenced
this pull request
Oct 10, 2024
The way it was done previously was too cute by half, looping over the abridged and unabridged spec file paths + conditionals galore, which confused coverage statistics. Also to the same end, make parsing the abridged spec file fail in relevant tests and don’t rely on rpm (>= 4.20) to do it (see fedora-infra#182). Signed-off-by: Nils Philippsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPM prior to version 4.20 failed to parse some abridged spec files. Newer versions are more robust, so the fall back path won’t be used.