Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of headers with trailing spaces between Viceroy and Fastly #380

Open
GeeWee opened this issue Jun 11, 2024 · 0 comments

Comments

@GeeWee
Copy link
Contributor

GeeWee commented Jun 11, 2024

If I make e.g. the following request to both viceroy and my service running on production fastly:

curl --request POST \
  --url https://my_compute_service.com \
  --header 'Authorization: Bearer    ' 

(notice the spaces at the end of the Authorization header)
and then print out the header value:

  • Viceroy prints "Bearer"
  • My live service prints "Bearer "

I have tests I'd like to be able to run on viceroy and know that my live service behaves the same way. Note that I think spec-wise Viceroy is doing the right thing, and the compute runtime is not. However, It'd be really nice for these environments to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant