Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for type hints #373

Open
yhay81 opened this issue Jan 24, 2021 · 1 comment
Open

Support for type hints #373

yhay81 opened this issue Jan 24, 2021 · 1 comment

Comments

@yhay81
Copy link
Contributor

yhay81 commented Jan 24, 2021

Some files have type hints and others do not.
I think writing type hints make it easier to understand the patterns.
I suggest to write type hints and if its okay, I will work some.

And there are two typing style now in python, so I would ask which is good, >=3.9 style or <3.9 style.
(mypy started to support for >=3.9 style just two days ago. https://mypy-lang.blogspot.com/2021/01/mypy-0800-released.html)

@faif
Copy link
Owner

faif commented Jan 25, 2021

Hi. Another contributor started adding type hints that's why some files have hints and some not. Feel free to continue with that but let's stick to <3.9 for now.

@2ykwang 2ykwang mentioned this issue Dec 6, 2021
2 tasks
yhay81 added a commit to yhay81/python-patterns that referenced this issue Feb 17, 2022
yhay81 added a commit to yhay81/python-patterns that referenced this issue Feb 17, 2022
@abe-101 abe-101 mentioned this issue Jul 19, 2022
1 task
This was referenced Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants