You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, even if we don't mount the source code for Faasm, we still mount the clients code (i.e. clients/cpp and clients/python) from ./clients/cpp and ./clients/python). I link the offending lines.
This has a domino effect:
Even if not mounting the source code, we need to clone faasmwith all the submodules. Theoretically, we could get away with just wget-ing the docker-compose.yml file, but that's not necessary neither. I think one shallow clone from the tag without submodule is enough (and can also be shared with k8s deployments).
Even if not mounting the source code, we need to wait for the venvs in client/{cpp,python}/venv/faasm_venv.BUILT.
Even if we bump the faasmctl version in clients/cpp (and bump the container tag to have faasmctl inside the contianer), we also need to bump the main faasm tag.
The text was updated successfully, but these errors were encountered:
The solution would be to remove the mount points from the docker-compose.yml file, and pass them as parameters from the command line in faasmctl (tasks/deploy.py).
Currently, even if we don't mount the source code for Faasm, we still mount the clients code (i.e. clients/cpp and clients/python) from
./clients/cpp
and./clients/python
). I link the offending lines.This has a domino effect:
faasm
with all the submodules. Theoretically, we could get away with justwget
-ing thedocker-compose.yml
file, but that's not necessary neither. I think one shallow clone from the tag without submodule is enough (and can also be shared withk8s
deployments).venv
s inclient/{cpp,python}/venv/faasm_venv.BUILT
.faasmctl
version inclients/cpp
(and bump the container tag to havefaasmctl
inside the contianer), we also need to bump the mainfaasm
tag.The text was updated successfully, but these errors were encountered: