Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clients mount for non-mounted compose clusters #14

Open
csegarragonz opened this issue Jul 13, 2023 · 1 comment
Open

Fix clients mount for non-mounted compose clusters #14

csegarragonz opened this issue Jul 13, 2023 · 1 comment

Comments

@csegarragonz
Copy link
Contributor

csegarragonz commented Jul 13, 2023

Currently, even if we don't mount the source code for Faasm, we still mount the clients code (i.e. clients/cpp and clients/python) from ./clients/cpp and ./clients/python). I link the offending lines.

This has a domino effect:

  1. Even if not mounting the source code, we need to clone faasm with all the submodules. Theoretically, we could get away with just wget-ing the docker-compose.yml file, but that's not necessary neither. I think one shallow clone from the tag without submodule is enough (and can also be shared with k8s deployments).
  2. Even if not mounting the source code, we need to wait for the venvs in client/{cpp,python}/venv/faasm_venv.BUILT.
  3. Even if we bump the faasmctl version in clients/cpp (and bump the container tag to have faasmctl inside the contianer), we also need to bump the main faasm tag.
@csegarragonz
Copy link
Contributor Author

The solution would be to remove the mount points from the docker-compose.yml file, and pass them as parameters from the command line in faasmctl (tasks/deploy.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant