Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the grid_info namespace #92

Open
eyalroz opened this issue Jun 9, 2021 · 0 comments
Open

Drop the grid_info namespace #92

eyalroz opened this issue Jun 9, 2021 · 0 comments
Assignees
@eyalroz
Labels
fixed on development A fix for this issue has been committed to the development branch Task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 9, 2021 •
edited
Loading

Using grid_info is cumbersome enough to defeat the purpose of these one-liner utility functions in the first place. While removing it may cause a bit of ambiguity in other namespace (e.g. collaborative::warp and collaborative::block) - it should still be ok for the users.

Part of #91.
@eyalroz eyalroz added the Task label Jun 9, 2021
@eyalroz eyalroz self-assigned this Jun 9, 2021
eyalroz pushed a commit that referenced this issue Jun 9, 2021
Fixes #92, regards #91: Dropped the grid_info namespace.
c767ab6
eyalroz pushed a commit that referenced this issue Jun 12, 2021
Fixes #92, regards #91: Dropped the grid_info namespace.
bc94213 
Also, preferring `lane::id()` over `lane::index()` when the latter was previously used.
@eyalroz eyalroz added the fixed on development A fix for this issue has been committed to the development branch label Jun 14, 2021
eyalroz pushed a commit that referenced this issue Jun 14, 2021
Fixes #92, regards #91: Dropped the grid_info namespace.
a774acd 
Also, preferring `lane::id()` over `lane::index()` when the latter was previously used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
fixed on development A fix for this issue has been committed to the development branch Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz