Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile uses deprecated gometalinter #30

Open
r8d8 opened this issue Aug 8, 2019 · 2 comments
Open

Makefile uses deprecated gometalinter #30

r8d8 opened this issue Aug 8, 2019 · 2 comments
Assignees
@r8d8
Labels
ISS: Annoyance Priority: 7 Low Type: Build Type: Configuration
Milestone
6.2 Atzlan & ...

Comments

@r8d8
Copy link

r8d8 commented Aug 8, 2019 •
edited
Loading

Currently Makefile uses deprecated gometalinter: https://github.com/etclabscore/go-ethereum/blob/development/Makefile#L75
Instead, one should use new golangci-lint
@r8d8 r8d8 added the ISS: Invalid This doesn't seem right label Aug 8, 2019
@triage-new-issues triage-new-issues bot removed the triage label Aug 8, 2019
@soc1c
Copy link
Contributor

soc1c commented Aug 8, 2019

Do you have capacity to fix the linter and add it to CI?

@r8d8
Copy link
Author

r8d8 commented Aug 8, 2019

Nope.
Linter gives 800 lines of errors/warnings, on default flags.

@soc1c soc1c added this to the 6.2 Atzlan & ... milestone Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r8d8 r8d8

Labels
ISS: Annoyance Priority: 7 Low Type: Build Type: Configuration
Projects
None yet
Milestone
6.2 Atzlan & ...
Development

No branches or pull requests
2 participants
@r8d8 @soc1c