refactor: use importlib instead of pkg_resources #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijis
force-pushed
the
refactor/pkg_resources
branch
from
0c6a993
to
26297d9
Compare
sijis
force-pushed
the
refactor/pkg_resources
branch
from
26297d9
to
cecbed6
Compare
sijis
force-pushed
the
refactor/pkg_resources
branch
from
ec6e448
to
8056027
Compare
sijis
force-pushed
the
refactor/pkg_resources
branch
from
8056027
to
d0d8e8a
Compare
I needed to further adjust the files lookup to ignore distributions that were not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to use importlib vs pkg_resources for processing packages as plugins.