-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get cover from url, not only file #97
Comments
Wouldn't this mean mpDris has to download the whole song – which may be quite large and possibly even an infinite radio stream... Not sure if that's doable unless mpd itself learns how to export the cover image. |
I made some tests and it looks like first 128 bytes are enough, something like http://ix.io/ADd/py . |
What about using something like this ? |
1 similar comment
What about using something like this ? |
If you set the |
I've been using these changes in the past, allowing one to specify a remote cover url. |
@wvengen, I'm a big fan of your solution so I've rebased your work on the latest master in my branch remote-art. Care to make it a PR? I do think this solves a different problem from @prietus , though. |
it seems like mpDris2 fetches covers only from files (or it looks to me), so when the url is e.g current song = {'file': 'http://192.168.1.128:9999/get_song?id=Tqoxmtzickfk33l22pl5hcy2t64' it does not grab cover, even when it is possible the same way it does for files.
I also tried recreating the album structure in the music_dir and putting a cover/front.jpg there with no success.
I'm I right supposing the latter approach won't work?
may you consider being able to grab the covers from http:// too?
thanks in advance.
The text was updated successfully, but these errors were encountered: