Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up test timeouts #310

Open
mdickinson opened this issue Apr 23, 2021 · 0 comments
Open

Clean up test timeouts #310

mdickinson opened this issue Apr 23, 2021 · 0 comments
Labels
component: tests type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs

Comments

@mdickinson
Copy link
Member

There are some inconsistencies related to test timeouts:

  • not all blocking calls currently have a timeout
  • we sometimes use SAFETY_TIMEOUT, sometimes TIMEOUT
  • let's use the same timeout throughout - a timeout of 5 seconds should be plenty big enough
@mdickinson mdickinson added the type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs label Apr 23, 2021
@mdickinson mdickinson mentioned this issue Apr 28, 2021
Closed
@mdickinson mdickinson mentioned this issue Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tests type: refactor Cleanup or refactoring tasks that don't add functionality or fix bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdickinson