Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Editor Widget - Pasting tabular data should paste as Table.input #11350

Closed
Tracked by #11183
AdRiley opened this issue Oct 17, 2024 · 7 comments · Fixed by #11695
Closed
Tracked by #11183

Table Editor Widget - Pasting tabular data should paste as Table.input #11350

AdRiley opened this issue Oct 17, 2024 · 7 comments · Fixed by #11695
Assignees
@vitvakatu
Labels
-gui x-new-feature Type: new feature request
Milestone
2024-12 Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Oct 17, 2024 •
edited by farmaazon
Loading

When we paste tabular data (e.g. from table viz) we should paste as a Table.input not .to Table
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Oct 17, 2024
@AdRiley AdRiley added this to the 2024-10 Release milestone Oct 17, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Oct 17, 2024 •
edited
Loading

Refinement notes:

  • If data is copied from AgGrid with "with headers" option, the pasted data in enso should recognize it and use these headers as column names. So the copy handler should consider it when putting enso code to the clipboard.
  • Remember about cases of newlines, tables (and quotes) in copied data - check how they are handled in other tools.

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Oct 17, 2024
@AdRiley AdRiley changed the title Pasting tabular data should paste as Table.new Table Editor Widget - Pasting tabular data should paste as Table.new Oct 29, 2024
@AdRiley AdRiley mentioned this issue Oct 29, 2024
Open
@farmaazon
Copy link
Contributor

After recent changes, it should be Table.input.

@farmaazon farmaazon changed the title Table Editor Widget - Pasting tabular data should paste as Table.new Table Editor Widget - Pasting tabular data should paste as Table.input Nov 21, 2024
@vitvakatu vitvakatu self-assigned this Nov 22, 2024
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Nov 22, 2024
@enso-bot
Copy link

enso-bot bot commented Nov 25, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-11-22):

Progress: Starting working on table pasting. Investigated and fixed a bug that prevented copying from aggrid on Mac. It should be finished by 2024-11-26.

@enso-bot
Copy link

enso-bot bot commented Nov 26, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-11-25):

Progress: Implementing csv parsing for copying and pasting tabular data. It should be finished by 2024-11-26.

@enso-bot
Copy link

enso-bot bot commented Nov 27, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-11-26):

Progress: Polishing the code and preparing the PR, noticed issues in “copy with headers” action. Discussed how to solve it on the daily. Also working on improving integration tests for table visualization. It should be finished by 2024-11-27.

@vitvakatu vitvakatu mentioned this issue Nov 28, 2024
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Nov 28, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-11-27):

Progress: Implementing fixes for spotted issues and adding tests. It should be finished by 2024-11-28.

@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Nov 28, 2024
@enso-bot
Copy link

enso-bot bot commented Nov 29, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-11-28):

Progress: Opening a PR. It should be finished by 2024-11-28.

@mergify mergify bot closed this as completed in #11695 Dec 3, 2024
mergify bot pushed a commit that referenced this issue Dec 3, 2024
@vitvakatu
Table.input for pasting tabular data (#11695)
4d2e44c 
Closes #11350

- Copy/pasting tabular data now creates `Table.input` nodes.
- Column names are always copied when you work inside Enso (excluding cases when you paste some cells into an existing table)
- When working with external apps, column names are copied only if `Copy with headers` is selected.

https://github.com/user-attachments/assets/a1233483-ee4a-47e4-84a1-64dd0b1505ef

Roundtrip with Google Spreadsheets (shows non-trivial TSV data that includes quotes and newlines):

https://github.com/user-attachments/assets/4ac662a2-809f-423a-9e47-628f46f92835
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 3, 2024
jdunkerley pushed a commit that referenced this issue Dec 3, 2024
@vitvakatu @jdunkerley
Table.input for pasting tabular data (#11695)
4b27850 
Closes #11350

- Copy/pasting tabular data now creates `Table.input` nodes.
- Column names are always copied when you work inside Enso (excluding cases when you paste some cells into an existing table)
- When working with external apps, column names are copied only if `Copy with headers` is selected.

https://github.com/user-attachments/assets/a1233483-ee4a-47e4-84a1-64dd0b1505ef

Roundtrip with Google Spreadsheets (shows non-trivial TSV data that includes quotes and newlines):

https://github.com/user-attachments/assets/4ac662a2-809f-423a-9e47-628f46f92835

(cherry picked from commit 4d2e44c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
-gui x-new-feature Type: new feature request
Projects
Issues Board
Status: 🟢 Accepted
Milestone
2024-12 Release
Development

Successfully merging a pull request may close this issue.

Table.input for pasting tabular data enso-org/enso
3 participants
@AdRiley @farmaazon @vitvakatu