SimpleSpawner: Add "rotate with parent" property #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what situation do you not want this to be |
I was only being extra careful with backwards compatibility. But yeah having |
Add yet another setting to the SimpleSpawner. This is to rotate the spawned scene according to the SimpleSpawner parent node. Useful for changing the direction of bullets spawned from a rotated object.
manuq
force-pushed
the
simple-spawner-rotation
branch
from
463bb4e
to
97efc15
Compare
|
Converting this to draft because I realize that I can use the global rotation, rather than the parent's rotation. And to address feedback from @dylanmccall over Slack. |
Use global rotation instead of (possibly none) parent rotation.
|
The alternative to this is: #294 |
|
I'm closing this in favour of #294, which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yet another setting to the SimpleSpawner. This is to rotate the spawned scene according to the SimpleSpawner parent node. Useful for changing the direction of bullets spawned from a rotated object.