Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(queries): Implementation using queries #5

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

jcs090218
Copy link
Member

No description provided.

@jcs090218 jcs090218 changed the title Implementation using queries refactor(queries): Implementation using queries Jul 6, 2022
@mohammedzeglam-pg
Copy link
Contributor

very helpful do you plan maybe add doc section to play with other unsupported

@jcs090218
Copy link
Member Author

We may not go for this approach since I realized there is a significant performance issue with this approach! I haven't have time to figure the performance culprit, but if you like, you could clone this branch and test it out this feature.

The performance issue is found in Emacs 29.0.50 with Windows OS.

@mohammedzeglam-pg
Copy link
Contributor

We may not go for this approach since I realized there is a significant performance issue with this approach! I haven't have time to figure the performance culprit, but if you like, you could clone this branch and test it out this feature.

The performance issue is found in Emacs 29.0.50 with Windows OS.

i do not have a windows machine now maybe after week i will try to see this issue and if this works fine could be more easily to add more functionality like injection and indent using tree-sitter

@mohammedzeglam-pg
Copy link
Contributor

mohammedzeglam-pg commented Jul 16, 2022

We may not go for this approach since I realized there is a significant performance issue with this approach! I haven't have time to figure the performance culprit, but if you like, you could clone this branch and test it out this feature.

The performance issue is found in Emacs 29.0.50 with Windows OS.

Hello i am sorry but this branch not even work i tried alot of language javascript-java-elixir-c-typescript-ruby all of them not works i use mac m1 with emacs 28.1 i will try to debug the code and why. not works but you could just add any language tree-sitter ships with his parser so could add elixir to modes supported.

and your way very clever to add inherit

@mohammedzeglam-pg
Copy link
Contributor

the problem here the value nil it could not get any folds in buffer
https://github.com/jcs-elpa/ts-fold/blob/28451ae9bed452394ea2c9d1d83c930730a56d35/ts-fold.el#L238

@mohammedzeglam-pg
Copy link
Contributor

The problem it was with straight.el

@mohammedzeglam-pg
Copy link
Contributor

Screen Shot 2022-07-16 at 6 00 44 PM

the range function has the same effect of use the old version of get range on old version that is why neovim uses block identifier....................................

@jcs090218
Copy link
Member Author

Sorry, for ignoring this issue. It took me a while to respond. (Was very busy with something else, and this take me to re-think some of the implementations)

TBH, I don't have enough knowledge on the queries implementation. So I don't want to bother people to work on things that are probably NOT going to get merged! It seems like you have already spent couple of hours on this in #13. 😓

But I don't want to stop people from doing thing that they are passionate on. So feel free to work on it if you really want this feature to be a thing! I appreciate your hard work! ❤️ 👍

@mohammedzeglam-pg
Copy link
Contributor

Sorry, for ignoring this issue. It took me a while to respond. (Was very busy with something else, and this take me to re-think some of the implementations)

TBH, I don't have enough knowledge on the queries implementation. So I don't want to bother people to work on things that are probably NOT going to get merged! It seems like you have already spent couple of hours on this in #13. 😓

But I don't want to stop people from doing thing that they are passionate on. So feel free to work on it if you really want this feature to be a thing! I appreciate your hard work! ❤️ 👍

I will try add and test more languages and i think this package really awesome, but i have now 3 projects to end before the next month and some other work, but if you have new idea about the design of the package feel free about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants