Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ipad 17 testing #5

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Feature/ipad 17 testing #5

merged 14 commits into from
Feb 2, 2024

Conversation

beyama
Copy link
Collaborator

@beyama beyama commented Jan 31, 2024

No description provided.

@beyama beyama changed the base branch from main to add-render-extensions-to-device-and-session January 31, 2024 11:02
@beyama beyama marked this pull request as ready for review January 31, 2024 12:55
Base automatically changed from add-render-extensions-to-device-and-session to main January 31, 2024 15:00
@r-dent r-dent marked this pull request as draft February 1, 2024 09:58
@beyama beyama marked this pull request as ready for review February 1, 2024 18:58
r-dent
r-dent approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@r-dent r-dent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot test crashes with an index-out-if-range error, when i change thetest_fling_on_touch_area test so that it fails. It is not a problem to me as long as it fails somehow. But maybe there is a way to let just the test fail?

@r-dent r-dent merged commit e197f77 into main Feb 2, 2024
1 check passed
@r-dent r-dent deleted the feature/IPAD-17-testing branch February 2, 2024 12:50
@beyama
Copy link
Collaborator Author

beyama commented Feb 2, 2024

@r-dent I wrapped the precondition checks (waitFor) in do/catch blocks and just used XCTFail so we do not have all those tries in the test. But maybe it makes sense to make precondition checks throwing (just like XCTUnwrap).
I created this draft PR for discussion. If you try to do a snapshot for a value in an array that doesn't exist there is not much I can do about but with this PR it should at least fail in case of a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-dent r-dent r-dent approved these changes

Assignees

@beyama beyama

@r-dent r-dent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beyama @r-dent