-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more details about the steps in the readme for newcomers #43
Comments
Great feedback, @AoDev. Thanks for posting. There is definitely room for improvement here.
Here's a PR that kicks off a code-signing tutorial: electron/electron#12767 -- once we get that landed we can link to it from here.
You have to publish your built application to GitHub Releases. The service expects to find a |
Thanks for the quick reply. The code-sign PR is cool, I'll look at it with more attention. :) For the Github Releases part, is there something I can do, apart from asking questions? Note that I have an open source pet project that I will use with this (awesome) service. But, I am actually interested in the same kind of service for a private repo, possibly commercial app. I don't want to go off topic, but if it's just a zip or an exe added to a Github release, can't people just create a "release repo", where they add the binaries to the releases, without putting actual code in the repo? Would that be a fair use of the service or something you wish not to happen? |
I hadn't considered that, but it's a great idea!
It looks like your project is using |
Another details question... I'm guessing the repo has to be set in the package.json like so...
Is that correct, and is that the only place it needs to be set? Thanks much. |
@Tapestes if you're using the update-electron-app module, then yes the repo is read from your package.json file. It can also be in this form:
... both are supported. |
In the readme, it is said:
Make sure that:
It would be useful to give more details about these.
Speaking as a newcomer to this kind of release flow.
"Github releases": do we need to attach / add the binaries to each drafted release? Or is the code somehow pulled, built and magically hosted?
"code-signed": how can one do this properly? some link and/or details?
For example, electron-builder has this doc
The text was updated successfully, but these errors were encountered: