Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sysroot downloader doesn't support electron 19+ #1043

Open
zawata opened this issue Nov 8, 2022 · 1 comment
Open

Sysroot downloader doesn't support electron 19+ #1043

zawata opened this issue Nov 8, 2022 · 1 comment

Comments

@zawata
Copy link

zawata commented Nov 8, 2022

Was experimenting with switching from our homemade native module rebuilder system to electron-rebuild when I ran into an issue:
image

The line of code that's failing:

const { Sha1Sum: sha, Tarball: fileName } = electronSysroots[`sid_${linuxArch}`];
fails because starting with electron 19, the sysroots are debian bullseye, not debian sid:
https://github.com/electron/electron/blob/59dd17f2cf0c816a718336d03667e42ca81ca187/script/sysroots.json

command:
npx electron-rebuild -v 21.2.2 --use-electron-clang

versions:

  • Manjaro 22.0.0
  • node 16.17
  • electron 21.2.2
  • electron-rebuild 3.2.9
@bencwallace
Copy link

Looks like this was fixed in #1046 but the version with these changes hasn't been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants