New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use electron_custom_version set by npm_config or npm_package_config #168

Open

ghost opened this issue Jul 31, 2020 · 0 comments

ghost commented Jul 31, 2020

It would be nice if the electron_custom_version option

get/src/index.ts

Line 81 in 607f621

process.env.ELECTRON_CUSTOM_VERSION || artifactDetails.version,

would also be searched for in the env vars set by the npm_config or npm_package_config similar to the other env var options

get/src/artifact-utils.ts

Lines 36 to 41 in 607f621

    
           process.env[`NPM_CONFIG_ELECTRON_${lowerName.toUpperCase()}`] || 
        
           process.env[`npm_config_electron_${lowerName}`] || 
        
           process.env[`npm_package_config_electron_${lowerName}`] || 
        
           process.env[`ELECTRON_${lowerName.toUpperCase()}`] || 
        
           options[name] || 
        
           defaultValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment