Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publisher-electron-release-server GET await (await authFetch('versions/sorted')).json(); in PublisherERS.ts this call (versions/sorted) has a limit of versions on key "items". #3698

Open
3 tasks done
PashaFG opened this issue Sep 15, 2024 · 0 comments

Comments

@PashaFG
Copy link

PashaFG commented Sep 15, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

32.1.0

Operating system

macOS 13.6.9 (22G830)

Last known working Electron Forge version

No response

Expected behavior

Behavior is similar to that described in #3430

Actual behavior

The problem is similar to that described in #3430.

  • similar behavior if we do not create a zip and dmg package. But we collect versions for darwin_x64 and darwin_arm64 architecture within one process on pnpm run publish.

Except that now we are not limited to the 30 versions returned by the old authFetch('api/version') endpoint.

But to the number of elements available for return in the authFetch('versions/sorted') endpoint, if we add an update to an older version. Since in the first N (default: 50), sorted by version name, we do not get the newly created one.

This number is regulated on the electron-release-server side. https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46
As a temporary solution, we can permanently increase this limit, but at the same time we increase the time until electron-release-server makes all the selection of files we need, which slows down the process of building our application.

Steps to reproduce

Create versions greater than specified in your electron-release-server settings https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46.

Attempt to build a new version with a name less than the last one returned in the authFetch('versions/sorted') endpoint

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants