Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): branch name with multiple / creates an invalid configuration #415

Open
davinkevin opened this issue Jul 22, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@davinkevin
Copy link

Hi 👋

I use a name convention for branches in my company, often like this: username/foo/bar.

In that context, when this code is evaluated, the result is:

repoCfg.GitHubRemote = "origin/username/foo
repoCfg.GitHubBranch = "bar"

This is off course invalid and prevents the system to work correctly.

Thanks

@davinkevin davinkevin changed the title fix(): branch name with multiple / created an invalid configuration fix(): branch name with multiple / creates an invalid configuration Jul 22, 2024
davinkevin added a commit to davinkevin/spr.go that referenced this issue Jul 22, 2024
davinkevin added a commit to davinkevin/spr.go that referenced this issue Jul 22, 2024
@chriscz chriscz added the bug Something isn't working label Sep 3, 2024
davinkevin added a commit to davinkevin/spr.go that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants