Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.spr.yml is overwritten with new values every time a git spr command is run. #410

Open
jameskyle opened this issue Jun 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jameskyle
Copy link

Steps to reproduce for 0.14.9:

Run git spr status or something, it generates a config file that looks something like

githubRepoOwner: TheOwner
githubRepoName: therepo
githubHost: github.com
requireChecks: true
requireApproval: true
githubRemote: origin
githubBranch: master
remoteBranches: []
mergeMethod: rebase

Make some changes something like...

githubRepoOwner: TheOwner
githubRepoName: therepo
githubHost: github.com
requireChecks: true
requireApproval: true
githubRemote: origin
githubBranch: develop
remoteBranches: []
mergeMethod: squash

Run git spr status again

Works as expected. Changes retained.

Now add something new

githubRepoOwner: TheOwner
githubRepoName: therepo
githubHost: github.com
requireChecks: true
requireApproval: true
githubRemote: origin
githubBranch: develop
remoteBranches: []
mergeMethod: squash
mergeQueue: true

Now run git status spr one more time

It overwrites the config and removes the mergeQueue option going back to

githubRepoOwner: TheOwner
githubRepoName: therepo
githubHost: github.com
requireChecks: true
requireApproval: true
githubRemote: origin
githubBranch: develop
remoteBranches: []
mergeMethod: squash

I also tested to remove something like githubBranch (which I understand should be auto-detected). It will overwrite the .spr.yml and set it to the default of master.

@jameskyle
Copy link
Author

I have a stack I can't merge due to needing the mergeQueue option.

@jameskyle
Copy link
Author

I walked back the versions to 0.14.6 and still see the behavior.

Oddly, I only see it with one of my repository. In a second repository, with mergeQueue also enabled, I do not see this behavior.

@chriscz chriscz added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants