Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useDirtyRect = true and saving image shows "Save as Image" label #16534

Closed
dirslashls opened this issue Feb 17, 2022 · 5 comments · May be fixed by ecomfe/zrender#891
Closed

useDirtyRect = true and saving image shows "Save as Image" label #16534

dirslashls opened this issue Feb 17, 2022 · 5 comments · May be fixed by ecomfe/zrender#891
Labels
difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English pending We are not sure about whether this is a bug/new feature. stale Inactive for a long time. Will be closed in 7 days. topic: toolbox waiting-for: community

Comments

@dirslashls
Copy link

Version

5.0.0

Link to Minimal Reproduction

No response

Steps to Reproduce

  1. Go to https://echarts.apache.org/examples/en/editor.html?c=line-step
  2. Turn on "Use Dirty Rect"
  3. Download the image.

Current Behavior

It contains the "Save as Image" label.

Expected Behavior

It should not contain the "Save as Image" label in the image.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response
@dirslashls dirslashls added the bug label Feb 17, 2022
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Feb 17, 2022
@plainheart plainheart added topic: toolbox difficulty: easy Issues that can be fixed more easily than the average. labels Feb 18, 2022
@echarts-bot
Copy link

echarts-bot bot commented Feb 18, 2022

This issue is labeled with difficulty: easy.
@dirslashls Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

@dirslashls
Copy link
Author

I am not 100% sure but I think excluded elements during rendering for image need to be explicitly cleared when setting useDirtyRect to true.

@linghaoSu linghaoSu mentioned this issue Feb 21, 2022
Open
@linghaoSu
Copy link
Member

@plainheart hi, I find the problem that caused the current issue in zrender, could you help me to review my pr?

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.

@github-actions github-actions bot added the stale Inactive for a long time. Will be closed in 7 days. label Feb 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English pending We are not sure about whether this is a bug/new feature. stale Inactive for a long time. Will be closed in 7 days. topic: toolbox waiting-for: community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dirtyRect): text dirty rect considered when text in host linghaoSu/zrender
3 participants
@dirslashls @plainheart @linghaoSu