Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X: Remove popcnt specialization #20653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spencer-Comin
Copy link
Contributor

With ipopcnt and lpopcnt IL opcodes implemented in OMR, the OpenJ9 specializations are no longer needed.

Depends on eclipse-omr/omr#7553

@Spencer-Comin Spencer-Comin marked this pull request as ready for review November 25, 2024 16:03
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

With ipopcnt and lpopcnt IL opcodes implemented in OMR, the OpenJ9
specializations are no longer needed.

Singed-off-by: Spencer Comin <[email protected]>
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

As this only affects x86, I shouldn't have run testing on all platforms - I'll ignore any problems on non-x86. Windows builds are out of commission at the moment, so I'll have to ignore those as well. Rerunning any other failing x86 builds.

Jenkins test sanity.functional xmac jdk11,jdk17 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

Jenkins test sanity.openjdk xmac jdk8 depends eclipse-omr/omr#7553

@hzongaro
Copy link
Member

Failure in JDK 8 xlinux sanity.functional testing appears to be due to known issue #18599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants