-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X: Remove popcnt specialization #20653
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.
With ipopcnt and lpopcnt IL opcodes implemented in OMR, the OpenJ9 specializations are no longer needed. Singed-off-by: Spencer Comin <[email protected]>
b096737
to
37a43ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7553 |
As this only affects x86, I shouldn't have run testing on all platforms - I'll ignore any problems on non-x86. Windows builds are out of commission at the moment, so I'll have to ignore those as well. Rerunning any other failing x86 builds. Jenkins test sanity.functional xmac jdk11,jdk17 depends eclipse-omr/omr#7553 |
Jenkins test sanity.openjdk xmac jdk8 depends eclipse-omr/omr#7553 |
Failure in JDK 8 xlinux sanity.functional testing appears to be due to known issue #18599 |
With
ipopcnt
andlpopcnt
IL opcodes implemented in OMR, the OpenJ9 specializations are no longer needed.Depends on eclipse-omr/omr#7553