Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detection of math library in numpy build #3520

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Nov 28, 2024

(created using eb --new-pr)

NumPy detects the required math by trying to link a minimal code containing a call to log(0.).
The first try is without any libraries, which works with gcc -fno-math-errno (our optimization default)
because the call gets removed due to not having any effect. So it concludes that -lm is not required.
This then fails to detect availability of functions such as acosh which do not get removed in the same
way and so less exact replacements are used instead which e.g. fail the tests on PPC.

$MATHLIB=m makes it try -lm first and is supported until the Meson backend is used in 1.26+.

The test code used is:

double log(double);

int main(){
  log(0.);
}

The issue can be reproduced by putting it in a file test.c and running:

$ gcc test.c
# OK
$ gcc -fno-math-errno test.c
/software/.../bin/ld: /tmp/ccGF6GFx.o: in function `main':
test.c:(.text+0x20): undefined reference to `log'
collect2: error: ld returned 1 exit status

On PPC I see test failures in e.g. SciPy-bundle-2023.02-gfbf-2022b.eb & SciPy-bundle-2023.07-gfbf-2023a.eb
FAILED core/tests/test_umath.py::TestComplexFunctions::test_loss_of_precision[complex256] - AssertionError: (120, 1.78095631306534887655740488957533e-10, 5.2863423150802063925011506713427e-21, 'arcsinh')

However the issue is not limited to PPC although the fallback functions seem to be "good enough" on x86.
A minimal example I made: https://godbolt.org/z/zGYcW45qE and one that it fails to detect casinh without -lm

Co-authored-by: Jan André Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants