Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force use of bash for Allwmake scripts in OpenFOAM easyblock #3519

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Nov 26, 2024

Fixes #3518 by running all Allwmake scripts with bash. I'm currently running a test build, see EESSI/software-layer#826 (comment).

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution as it also makes sure to use the bash in the current path

@bedroge
Copy link
Contributor Author

bedroge commented Nov 27, 2024

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--installpath=/tmp/$USER/pr3388 OpenFOAM-8-foss-2020a.eb OpenFOAM-9-foss-2021a.eb OpenFOAM-10-foss-2022a.eb OpenFOAM-11-foss-2023a.eb OpenFOAM-v2106-foss-2021a.eb OpenFOAM-v2112-foss-2021b.eb OpenFOAM-v2206-foss-2022a.eb OpenFOAM-v2306-foss-2022b.eb OpenFOAM-v2312-foss-2023a.eb OpenFOAM-v2406-foss-2023a.eb"

@boegelbot
Copy link

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=3519 EB_ARGS="--installpath=/tmp/$USER/pr3388 OpenFOAM-8-foss-2020a.eb OpenFOAM-9-foss-2021a.eb OpenFOAM-10-foss-2022a.eb OpenFOAM-11-foss-2023a.eb OpenFOAM-v2106-foss-2021a.eb OpenFOAM-v2112-foss-2021b.eb OpenFOAM-v2206-foss-2022a.eb OpenFOAM-v2306-foss-2022b.eb OpenFOAM-v2312-foss-2023a.eb OpenFOAM-v2406-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3519 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14769

Test results coming soon (I hope)...

- notification for comment with ID 2503267885 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Contributor Author

bedroge commented Nov 27, 2024

I like this solution as it also makes sure to use the bash in the current path

True, and I initially even suspected that this was the issue for EESSI. But other people reported the same issue on Slack, so apparently it's really related to dash being used.

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-8-foss-2020a.eb
  • SUCCESS OpenFOAM-9-foss-2021a.eb
  • SUCCESS OpenFOAM-10-foss-2022a.eb
  • SUCCESS OpenFOAM-11-foss-2023a.eb
  • SUCCESS OpenFOAM-v2106-foss-2021a.eb
  • SUCCESS OpenFOAM-v2112-foss-2021b.eb
  • SUCCESS OpenFOAM-v2206-foss-2022a.eb
  • SUCCESS OpenFOAM-v2306-foss-2022b.eb
  • SUCCESS OpenFOAM-v2312-foss-2023a.eb
  • SUCCESS OpenFOAM-v2406-foss-2023a.eb

Build succeeded for 10 out of 10 (10 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fb109f11afe244a4618a6003fb9079ca for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 358c719 into easybuilders:develop Nov 27, 2024
41 checks passed
@bedroge bedroge deleted the openfoam_bash_allwmake branch November 27, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenFOAM v2406 fails to build the plugins on systems with /bin/sh -> dash
3 participants