-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force use of bash
for Allwmake
scripts in OpenFOAM easyblock
#3519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this solution as it also makes sure to use the bash
in the current path
@boegelbot please test @ generoso |
@bedroge: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2503267885 processed Message to humans: this is just bookkeeping information for me, |
True, and I initially even suspected that this was the issue for EESSI. But other people reported the same issue on Slack, so apparently it's really related to dash being used. |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 10 out of 10 (10 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #3518 by running all
Allwmake
scripts withbash
. I'm currently running a test build, see EESSI/software-layer#826 (comment).