Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve product page #128

Open
dvjsharma opened this issue Jul 9, 2024 · 8 comments
Open

Improve product page #128

dvjsharma opened this issue Jul 9, 2024 · 8 comments
Assignees
Labels

Comments

@dvjsharma
Copy link
Owner

Description

image

The product page needs a better design.

@dvjsharma dvjsharma added good first issue Good for newcomers gssoc GSSoC'24 label level2 Priority High labels Jul 9, 2024
@UtkarshBirla28
Copy link

@dvjsharma assign this issue to me sir will resolve it ASAP

@dvjsharma
Copy link
Owner Author

Go ahead @UtkarshBirla28

@Shruti2183
Copy link

@dvjsharma could you pls specify how u want your page to be? i can make it better!

@dvjsharma
Copy link
Owner Author

Hi @Shruti2183, maybe something like the below. Feel free to experiment and finalize a design.

image

@Shruti2183
Copy link

Shruti2183 commented Oct 1, 2024

Screenshot (25)
i made this is it okay? or does this need to be improved? i did this in css.

@dvjsharma
Copy link
Owner Author

Ah sorry, missed the comment. Few questions:

  • Where are you getting these pictures from?
  • The price is also new, haven't seen in previous data. Is there any DB change?
  • Select size buttons can have a better color scheme :)

Rest looks good!

@Shruti2183
Copy link

i took those from official webiste of nike.
no DB change has happened
okay, maybe i can play around in shades of green

@dvjsharma
Copy link
Owner Author

Instead green, I'll suggest playing around with shades of black and grey to match the website theme. Since there is no DB change, where are we getting this image from? My concern with the image is:

  • We should have a store for this.
  • Since we are custom shoes, plain designs won't work. We have a few designs but having multiple photos for same design is a bit tricky (we can't find any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants