Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect year length #116

Open
chrisgilbert opened this issue Jul 30, 2023 · 1 comment
Open

Incorrect year length #116

chrisgilbert opened this issue Jul 30, 2023 · 1 comment

Comments

@chrisgilbert
Copy link

const (

I just noticed when scanning the docs that a year here is a multiple of 12 months, and since each month is considered 30 days, that gives a 360 days year. I assume this is not intended, though it seems financial calculations sometimes use a 360 day year. I guess it should be 365.25 days.

I suppose it wouldn’t likely be noticed unless you were doing multi year calculations though.

@dustin
Copy link
Owner

dustin commented Jul 30, 2023

Given the rounding, it's not super likely to be noticeable, but a demonstration in a unit test would justify a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants