New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RIGHT JOIN, changed default behaviour of JOIN #7

Closed

oshamin opened this issue Mar 28, 2014 · 1 comment

Contributor

oshamin commented Mar 28, 2014

Added RIGHT JOIN.
Changed default behaviour of JOIN from LEFT JOIN to INNER JOIN.

https://github.com/oshamin/simpleSqlParser/commit/50bf0bd4b3b50d71c1679f38a5aada163d37f65e

Owner

dsferruzza commented Mar 31, 2014

Hi!

Thanks for your contribution!
The changes you made totally make sense, but there are some minor issues with your implementation:

you should have done 2 commits because there are 2 different changes
you have used spaces for indentation whereas the rest of the project uses tabs

If you fix these issues and make a pull request, I'll merge it!
Is this OK for you?
You seem new to GitHub, so tell me if you need help.

Also, I'm starting to think about rewriting the whole project.
Feel free to comment #6 !

dsferruzza closed this as completed in

2229dba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment