Add minimum image age option #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
reviewed
May 7, 2020
| Pretty bool `envconfig:"GC_DEBUG_PRETTY"` | ||
| Images []string `envconfig:"GC_IGNORE_IMAGES"` | ||
| Containers []string `envconfig:"GC_IGNORE_CONTAINERS"` | ||
| Interval time.Duration `envconfig:"GC_INTERVAL" default:"5m"` |
There was a problem hiding this comment.
Yes sorry, I now gofmted all my changes
kaisoz
force-pushed
the
add-minimum-image-age-option
branch
from
5a9d8d0
to
77a0cfd
Compare
tboerger
approved these changes
May 8, 2020
|
@tboerger is there any possibility to see this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of DroneGC only considers images that were created more than one hour ago. This PR makes that image age time configurable via the
MinImageAgeoption. If such option is not available, the minimum image age is remains 1 hour.