docker login opt #53
Open
docker login opt #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you need to authenticate at this stage? |
frebib
reviewed
Jan 11, 2020
| @@ -143,9 +147,23 @@ poller: | |||
|
|
|||
| logger.Debug(). | |||
| Str("image", i.image). | |||
| Msg("pull docker image") | |||
| Msg("pull docker image") | |||
frebib
reviewed
Jan 11, 2020
| @@ -57,6 +57,8 @@ type ( | |||
| Environ []string | |||
| Volumes []string | |||
| Labels map[string]string `envconfig:"DRONE_AGENT_LABELS"` | |||
| Dockerusername string `envconfig:"DRONE_AGENT_DOCKER_USERNAME"` | |||
There was a problem hiding this comment.
Indentation. You should run gofmt -w **/*.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuration option to use a private docker image.