Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy > 1.26.4 #1104

Open
Mikeriess opened this issue Aug 19, 2024 · 4 comments · May be fixed by #1265
Open

Numpy > 1.26.4 #1104

Mikeriess opened this issue Aug 19, 2024 · 4 comments · May be fixed by #1265
Labels
enhancement

Comments

@Mikeriess
Copy link

What behavior of the library made you think about the improvement?

This issue is just meant as a Q&A, as I couldnt find anything specifically on this.

The question is why there is a dependency on older versions of numpy? What is the limitation in the newer numpy versions? And how big of a job do you estimate it would be to support newer versions of numpy?

How would you like it to behave?

Numpy > 1.26.4
@lapp0
Copy link
Contributor

lapp0 commented Aug 19, 2024 •
edited
Loading

@Mikeriess I don't think it would be a substantial effort.

We pinned to numpy 1 due to

The imports would need to be fixed. Unless there's something I'm missing this is a trivial change.

@Mikeriess
Copy link
Author

Mikeriess commented Sep 1, 2024 •
edited
Loading

Got it. Have had some compatibility issues with outlines and the newest llama.cpp version due to this, so if this is a trivial change that is great news 👍

@lapp0
Copy link
Contributor

lapp0 commented Sep 1, 2024 •
edited
Loading

Got it. Have had some compatibility issues with outlines and the newest llama.cpp version due to this, so if this is a trivial change that is great news 👍

Is the latest llama.cpp incompatible with numpy<2.0.0? If so, could you please share your error?

I'd like to ensure this is high priority if it breaks the latest llama.cpp.

@smallstepman
Copy link

https://github.com/abetlen/llama-cpp-python/blob/9769e5719ad45d4be6bc3ebe01d0f568d3d5001e/pyproject.toml#L16

https://github.com/vllm-project/vllm/blob/5231f0898e559671c6c8cc48efc53a859fce1841/requirements-common.txt#L3

looks like everyone is lagging behind

@neilmehta24 neilmehta24 linked a pull request Nov 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility for numpy 2 while preserving numpy 1 compatibility neilmehta24/outlines
3 participants
@lapp0 @Mikeriess @smallstepman