Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark #11954

Open
Olina-Zhang opened this issue Aug 21, 2024 · 2 comments · May be fixed by #12420
Open

[Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark #11954

Olina-Zhang opened this issue Aug 21, 2024 · 2 comments · May be fixed by #12420
Labels
area-DarkMode Issues relating to Dark Mode feature 🚧 work in progress Work that is current in progress help wanted Good issue for external contributors
Milestone
Help wanted

Comments

@Olina-Zhang
Copy link
Member

.NET version

9.0.0-rc.1.24418.2 + private dlls built from winforms repo main branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: #11857

Issue description

ToolTip is not in dark mode after enabled SystemColorMode.Dark
image

Steps to reproduce

  1. Create a WinForms .NET application with checkBox and toolTip controls
  2. Find the ToolTip on toolTip1 property of checkBox, then set some text for this property
  3. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in Program.cs file
  4. Run application, tab or mouse over this checkBox to observe the keyboard tooltip or mouse tooltip
@Olina-Zhang Olina-Zhang added untriaged The team needs to look at this issue in the next triage area-DarkMode Issues relating to Dark Mode feature labels Aug 21, 2024
@merriemcgaw merriemcgaw added help wanted Good issue for external contributors and removed untriaged The team needs to look at this issue in the next triage labels Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Help wanted milestone Sep 4, 2024
@willibrandon
Copy link
Contributor

Not sure why, but it seems the TTM_SETTIPBKCOLOR message is ignored when visual style is enabled on the control. If I disable it, then I can set the ToolTip BackColor and ForeColor.

Image

Could a possible fix could be something similar to how the ToolTip is made contrasted enough in HC mode?

winforms/src/System.Windows.Forms/src/System/Windows/Forms/ToolTip/ToolTip.cs

Lines 717 to 720 in c9aa1c9

if (SystemInformation.HighContrast)
{
PInvoke.SetWindowTheme(HWND, string.Empty, string.Empty);
}

@willibrandon
Copy link
Contributor

The unit test would be to retrieve the background color and text color for a tooltip window using messages TTM_GETTIPBKCOLOR and TTM_GETTIPTEXTCOLOR, and assert the values returned are equal to SystemColors.Info and SystemColors.InfoText.

I believe that test fails right now when Dark mode is enabled.

@willibrandon willibrandon linked a pull request Nov 4, 2024 that will close this issue
Draft
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-DarkMode Issues relating to Dark Mode feature 🚧 work in progress Work that is current in progress help wanted Good issue for external contributors
Projects
None yet
Milestone
Help wanted
Development

Successfully merging a pull request may close this issue.

Style ToolTip to make it dark enough in Dark mode willibrandon/winforms
3 participants
@willibrandon @merriemcgaw @Olina-Zhang