Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Binding Sources not seen as a binding source? #12361

Open
MaceySoftware opened this issue Oct 21, 2024 · 2 comments
Open

Custom Binding Sources not seen as a binding source? #12361

MaceySoftware opened this issue Oct 21, 2024 · 2 comments
Assignees
Labels
area-VSDesigner Windows Forms out-of-proc designer related issues untriaged The team needs to look at this issue in the next triage
Milestone

Comments

@MaceySoftware
Copy link

Environment

Version: 17.10.2

.NET version

.Net 8 in this example, our actual application is running 4.8.

Did this work in a previous version of Visual Studio and/or previous .NET release?

It worked in visual studio 2019 as it wasn't using the out of process designer

Issue description

Out of process designer doesn't correctly identify custom binding sources and therefore inject extra binding sources when attempting to set them up.

Steps to reproduce

  1. Setup project so it uses the out of process designer
  2. Add a new class called "MyCustomBindingSource"
  3. Inherit System.Windows.Forms.BindingSource
  4. Build project
  5. Add MyCustomBindingSource to form
  6. Set the datasource property as you normally would
    Issue 1, the datasource property doesn't get set via the window however this is already logged here: Bindingsource not assigned #8908

Image

  1. Use work around to set the datasource property via the other datasource section
    Issue 2, A extra binding source has been added to the form which has been setup correctly and the MyCustomBindingSource datasource property has been set to that bindingsource.
    Image

Project can be downloaded here if you want to be able to skip to step 4

DataBindingIssue.zip

Regards

Diagnostics

No response

@MaceySoftware MaceySoftware added the untriaged The team needs to look at this issue in the next triage label Oct 21, 2024
@elachlan elachlan added the area-VSDesigner Windows Forms out-of-proc designer related issues label Oct 22, 2024
@JeremyKuhne JeremyKuhne added this to the VS release milestone Oct 22, 2024
@merriemcgaw
Copy link
Member

@Olina-Zhang can you verify this and then copy it into the designer repo if there isn't a duplicate in there already? We'll circle back after the full investigation.

@Zheng-Li01
Copy link
Member

@merriemcgaw, copied the issue into the designer repo 6175 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VSDesigner Windows Forms out-of-proc designer related issues untriaged The team needs to look at this issue in the next triage
Projects
None yet
Development

No branches or pull requests

6 participants