fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI #12363

Epica3055 · 2024-10-22T02:09:03Z

Fixes #12358

Proposed changes

Revert PR Create AccessibleObject for PrintStatusDialog #11523

Regression?

Yes

Risk

low

Screenshots

Before

After

Test methodology

manual

Microsoft Reviewers: Open in CodeFlow

codecov · 2024-10-22T02:42:52Z

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.73717%. Comparing base (e8a65f9) to head (a23da97).
Report is 105 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12363         +/-   ##
===================================================
+ Coverage   75.64857%   75.73717%   +0.08859%     
===================================================
  Files           3120        3159         +39     
  Lines         635396      636113        +717     
  Branches       46933       47001         +68     
===================================================
+ Hits          480668      481774       +1106     
+ Misses        151270      150868        -402     
- Partials        3458        3471         +13

Flag	Coverage Δ
Debug	`75.73717% <5.71429%> (+0.08859%)`	⬆️
integration	`18.17861% <0.00000%> (-0.10380%)`	⬇️
production	`49.30080% <5.71429%> (+0.09681%)`	⬆️
test	`97.04530% <ø> (+0.01837%)`	⬆️
unit	`46.51736% <5.71429%> (+0.36854%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

…ws” dialog is truncated at >200% DPI

LeafShi1

LGTM!

lonitra · 2024-10-22T21:57:23Z

Changes seem fine to me, but could we do testing on this to make sure there are no other regressions

This reverts commit 1644a6c.

…g Previews” dialog is truncated at >200% DPI" This reverts commit 034658b.

...dows.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.StatusDialog.cs

This reverts commit c1c8ea3.

This reverts commit a7ff088.

…ng Previews” dialog is truncated at >200% DPI" This reverts commit 7cf77c6.

This reverts commit 833c20a.

Philip-Wang01 · 2024-10-31T09:36:53Z

Tested private dlls for this PR, here is the result.

For 11456, issue3(An error was detected by using Accessibility Insight tool for the "Page 1 of document" pattern) has been fixed. Currently only Narrator can't announce “Generating Previews”, NVDA and JAWS can announce it correctly, and isDialog and AccessibleName properties are correct.

For 12358, three regression HDPI issues (compared with the behaviors in .NET 8.0) still repro. See details in the team's channel.

...dows.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.StatusDialog.cs

...ws.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.FocusableLabel.cs

Tanya-Solyanik · 2024-11-04T19:18:30Z

@Epica3055 - what accessible properties differ between the Label and the LinkLabel? Let's review them and any important property, like ControlType, can be fixed in a custom accessible object.

Epica3055 · 2024-11-05T02:20:10Z

@Tanya-Solyanik
I created a demo project.

Tanya-Solyanik · 2024-11-05T18:57:46Z

Name and Automation Id properties are in your control, it will be set here - internal Label _messageLabel;
The problem is the child heirarchy. Could you please try to get rid of it, start by not having any links, then if that does not work, implement a custom accessible object that overrides the Navigation methods - FragmentNavigate, GetChild, GetChildCount

Tanya-Solyanik

Changes look good, could you please get them tested under different screen readers

...ws.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.FocusableLabel.cs

Philip-Wang01 · 2024-11-12T10:12:51Z

Tested private dlls for this PR, here is the result.

For #11456, One behavior needs to be confirmed. Narrator still can't announce “Generating Previews”, NVDA announce it correctly, and isDialog and AccessibleName properties are correct.

For #12358, all HDPI issues have been fixed and there are no new regressions.

Tanya-Solyanik · 2024-11-13T01:09:26Z

Please investigate how to override AccessibleRole and ControlType for the new object

Epica3055 · 2024-11-20T01:45:25Z

@Tanya-Solyanik

When we focus on LinkLabel using AccessibleTool, we actually focus on Link.
So we need to change Link AccessibleRole , please review latest commit in this pr to see if that's acceptable.

Tanya-Solyanik · 2024-11-20T21:54:38Z

src/System.Windows.Forms/src/System/Windows/Forms/Controls/Labels/LinkLabel.cs

@@ -142,6 +142,8 @@ private Color IEDisabledLinkColor
        }
    }

+    internal virtual AccessibleRole LinkAccessibleRole => AccessibleRole.Link;


Can we set the Control.AccessibleRole property instead?

I don't think we can.

JAWS announce “Page 1 of document” with the suffix changed from text to link, it announce “page 1 of document link”

The real problem here is in Link, not in LinkLabel.

It seems impossible to change Link.AccessibleRole from outside. So I changed our code to let Link.AccessibleRole rely on LinkLabel so that I can customize Link.AccessibleRole.

Tanya-Solyanik · 2024-11-20T21:58:46Z

...ws.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.FocusableLabel.cs

+
+public partial class PrintControllerWithStatusDialog
+{
+    private class FocusableLabel : LinkLabel


Note for the future - we might have other instances of dialogs where we need a focusable label, we'll "un-nest" this class if needed.

Epica3055 requested a review from a team as a code owner October 22, 2024 02:09

dotnet-policy-service bot assigned Epica3055 Oct 22, 2024

fix dotnet#12358 [HDPI] The "document" text in the “Generating Previe…

034658b

…ws” dialog is truncated at >200% DPI

Epica3055 force-pushed the Fix_Issue_12358 branch from a2b6bdb to 034658b Compare October 22, 2024 06:34

LeafShi1 reviewed Oct 22, 2024

View reviewed changes

lonitra added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 22, 2024

Epica3055 added 4 commits October 24, 2024 16:29

fix issue

1644a6c

Revert "fix issue"

833c20a

This reverts commit 1644a6c.

Revert "fix dotnet#12358 [HDPI] The "document" text in the “Generatin…

7cf77c6

…g Previews” dialog is truncated at >200% DPI" This reverts commit 034658b.

revert PR 11523

a7ff088

Tanya-Solyanik reviewed Oct 28, 2024

View reviewed changes

...dows.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.StatusDialog.cs Show resolved Hide resolved

fix test issue

c1c8ea3

Epica3055 removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 30, 2024

Epica3055 added 5 commits October 30, 2024 14:07

Revert "fix test issue"

1c10a2c

This reverts commit c1c8ea3.

Revert "revert PR 11523"

2f2cb46

This reverts commit a7ff088.

Reapply "fix dotnet#12358 [HDPI] The "document" text in the “Generati…

752faf3

…ng Previews” dialog is truncated at >200% DPI" This reverts commit 7cf77c6.

Reapply "fix issue"

47dc56e

This reverts commit 833c20a.

fix issues found by test teams

45f6f23

Tanya-Solyanik added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 30, 2024

Philip-Wang01 removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 31, 2024

Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Nov 1, 2024

another approach

2f1a69f

dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 1, 2024

LeafShi1 added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 1, 2024

Tanya-Solyanik reviewed Nov 1, 2024

View reviewed changes

...dows.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.StatusDialog.cs Outdated Show resolved Hide resolved

Tanya-Solyanik reviewed Nov 1, 2024

View reviewed changes

...ws.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.FocusableLabel.cs Outdated Show resolved Hide resolved

Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Nov 1, 2024

dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 4, 2024

Tanya-Solyanik removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 5, 2024

Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Nov 5, 2024

dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 6, 2024

fix comments

5301f92

Epica3055 force-pushed the Fix_Issue_12358 branch from 4ac7efe to 5301f92 Compare November 6, 2024 07:13

Epica3055 added the waiting-review This item is waiting on review by one or more members of team label Nov 7, 2024

Tanya-Solyanik reviewed Nov 12, 2024

View reviewed changes

...ws.Forms/src/System/Windows/Forms/Printing/PrintControllerWithStatusDialog.FocusableLabel.cs Outdated Show resolved Hide resolved

Tanya-Solyanik added 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) and removed waiting-review This item is waiting on review by one or more members of team labels Nov 12, 2024

move FocusableLabelAccessibleObject into a dedicated file.

ae1c995

Philip-Wang01 removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 12, 2024

Remove 'link' in "link, page 1 of document"

109e091

LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Nov 15, 2024

Tanya-Solyanik reviewed Nov 20, 2024

View reviewed changes

fix comments

a23da97

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI #12363

fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI #12363

Epica3055 commented Oct 22, 2024 •

edited

Loading

codecov bot commented Oct 22, 2024 •

edited

Loading

LeafShi1 left a comment

lonitra commented Oct 22, 2024

Philip-Wang01 commented Oct 31, 2024

Tanya-Solyanik commented Nov 4, 2024 •

edited

Loading

Epica3055 commented Nov 5, 2024

Tanya-Solyanik commented Nov 5, 2024

Tanya-Solyanik left a comment

Philip-Wang01 commented Nov 12, 2024

Tanya-Solyanik commented Nov 13, 2024 •

edited

Loading

Epica3055 commented Nov 20, 2024

Tanya-Solyanik Nov 20, 2024

Epica3055 Nov 21, 2024

Tanya-Solyanik Nov 20, 2024

fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI #12363

Are you sure you want to change the base?

fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI #12363

Conversation

Epica3055 commented Oct 22, 2024 • edited Loading

Proposed changes

Regression?

Risk

Screenshots

Before

After

Test methodology

Microsoft Reviewers: Open in CodeFlow

codecov bot commented Oct 22, 2024 • edited Loading

Codecov Report

LeafShi1 left a comment

Choose a reason for hiding this comment

lonitra commented Oct 22, 2024

Philip-Wang01 commented Oct 31, 2024

Tanya-Solyanik commented Nov 4, 2024 • edited Loading

Epica3055 commented Nov 5, 2024

Tanya-Solyanik commented Nov 5, 2024

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Philip-Wang01 commented Nov 12, 2024

Tanya-Solyanik commented Nov 13, 2024 • edited Loading

Epica3055 commented Nov 20, 2024

Tanya-Solyanik Nov 20, 2024

Choose a reason for hiding this comment

Epica3055 Nov 21, 2024

Choose a reason for hiding this comment

Tanya-Solyanik Nov 20, 2024

Choose a reason for hiding this comment

Epica3055 commented Oct 22, 2024 •

edited

Loading

codecov bot commented Oct 22, 2024 •

edited

Loading

Tanya-Solyanik commented Nov 4, 2024 •

edited

Loading

Tanya-Solyanik commented Nov 13, 2024 •

edited

Loading