Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure download counts can go beyond 2.4B #134

Open
bruno-garcia opened this issue Apr 1, 2021 · 0 comments
Open

Ensure download counts can go beyond 2.4B #134

bruno-garcia opened this issue Apr 1, 2021 · 0 comments

Comments

@bruno-garcia
Copy link
Member

As Newtonsoft.Json's count is reaching int.MaxValue, this issue was raised:
NuGet/NuGetGallery#8476

At first glance, we're using long already for the count:

nuget-trends/src/NuGetTrends.Data/DailyDownload.cs

Line 9 in dac67d1

public long? DownloadCount { get; set; }

We need to make sure things will work fine once values overflow a signed 32bit integer max value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bruno-garcia