Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git pre-commit hooks for applying formatting to source #27632

Open
captainsafia opened this issue Nov 8, 2020 · 1 comment · May be fixed by #58965
Open

Add git pre-commit hooks for applying formatting to source #27632

captainsafia opened this issue Nov 8, 2020 · 1 comment · May be fixed by #58965
Labels
affected-medium This issue impacts approximately half of our customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Milestone
Backlog

Comments

@captainsafia
Copy link
Member

Our repos formatting currently defaults to the formatting applied by default in VS. This can be cumbersome for users who are working in non-VS editors with the repo or users who disable format on save in their IDE.

We should consider adding a git pre-commit hook that runs dotnet format on modified source files in a particular change set.
@captainsafia captainsafia added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Nov 8, 2020
This was referenced Nov 8, 2020
Closed
Open
@ShreyasJejurkar ShreyasJejurkar mentioned this issue Nov 11, 2020
Merged
@wtgodbe wtgodbe added affected-medium This issue impacts approximately half of our customers severity-nice-to-have This label is used by an internal tool labels Dec 7, 2020 — with ASP.NET Core Issue Ranking
@SteveSandersonMS SteveSandersonMS mentioned this issue Feb 12, 2021
Merged
@SteveSandersonMS
Copy link
Member

Reopening as per #30145

@ShreyasJejurkar ShreyasJejurkar mentioned this issue Mar 13, 2021
Closed
@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Nov 5, 2024
@nazolek nazolek linked a pull request Nov 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-medium This issue impacts approximately half of our customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add pre-commit hook with code formatting nazolek/aspnetcore
5 participants
@SteveSandersonMS @captainsafia @wtgodbe @mkArtakMSFT and others