Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set timeouts on requests calls #127

Open
hmoffatt opened this issue Dec 6, 2023 · 0 comments
Open

set timeouts on requests calls #127

hmoffatt opened this issue Dec 6, 2023 · 0 comments

Comments

@hmoffatt
Copy link
Contributor

hmoffatt commented Dec 6, 2023

pylti1.3 uses requests to interact with the tool consumer, but does not set any timeout on the requests calls. As per the documentation, timeouts should always be set in production. https://docs.python-requests.org/en/latest/user/advanced/#timeouts

Requests may introduce a default in the future, but currently has none. See psf/requests#3070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant