FontLoader localStorage

[onedrop]

FontLoader checks for localStorage like so... if(localStorage). This doesn't handle the case where the browser does in fact support localStorage but its been disabled via browser configuration/preferences. In this circumstance, an access is denied error will be thrown by the browser when attempting to access localStorage.

I noticed a TODO for this in the code already but was hoping you could address this and release a new version of the library. Using a function like this to check for localStorage availability will resolve the issue...

function hasLocalStorage(){
	var item = 'check'
	try {
		localStorage.setItem(item, item);
		localStorage.removeItem(item);
		return true;
	} catch(e) {
		return false;
	}	
}

Thanks!

[diverted247]

Nice catch. Will add and release within the week.

[slahav]

Any update on this?

[diverted247]

No progress yet. If you wanted to do a pull request it would speed things. I want to make sure what is added is essential vs something that can be done externally.

[onedrop]

Added a PR for this... #29

[slahav]

@diverted247 can you please review #29

[mmoss]

It would be great if we could get some traction on #29