Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Is broken - Node? More like OLD! #312

Open
sshirokov opened this issue Jul 2, 2018 · 0 comments
Open

CI Is broken - Node? More like OLD! #312

sshirokov opened this issue Jul 2, 2018 · 0 comments
Assignees

Comments

@sshirokov
Copy link
Member

We pinned node to an ancient version a while back just to make sure it doesn't break, but the steady progress of time has once again decayed everything around us in as much time as it takes to catch your breath before we realized it, and now the dependant test suites fail to load for some of our direct dependencies because they use "advanced" ECMAScript features like "let" and "const" which our version of node has never heard of.

What we need to do is upgrade node to a version that doesn't run too far away from us in APIs or internals (so that we can still build libgd for AYP) but has support for "modern" JS so we can actually run our test suites.

Once we can get CI to pass, I can update https://github.com/desert-planet/hayt-vagrant to make sure AYP works, and then production and everything Will Be Good. And stop just ignoring the fact that our idiot robot is bleeding to death.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants