Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select nodes with space does not work anymore #2297

Closed
WZHGAHO opened this issue Nov 14, 2023 · 5 comments
Closed

Select nodes with space does not work anymore #2297

WZHGAHO opened this issue Nov 14, 2023 · 5 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@WZHGAHO
Copy link

WZHGAHO commented Nov 14, 2023




Describe the bug
It seems selecting nodes in Node view using Space does not work anymore. However I'm not sure if it was working ever in previous versions.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Nodes'
  2. Try to press Space and select multiple nodes
  3. It does not select the nodes.

Expected behavior
Space would select multiple nodes in Node view.

Versions :

  • OS: Linux
  • K9s: 0.28.2
  • K8s: v1.28.3-eks-4f4795d

Can you please investigate the problem?
@wjiec
Copy link
Contributor

wjiec commented Nov 15, 2023

It's explicitly disabled here

k9s/internal/view/node.go

Line 54 in 0d6805f

aa.Delete(ui.KeySpace, tcell.KeyCtrlSpace)

I'm guessing it's because operations involving Node are dangerous and shouldn't provide batch functionality.

@olfway
Copy link

olfway commented Nov 15, 2023

Please, revert it, it's very useful

and it's much safer to select nodes first and then delete all than removing a lot of nodes one–by–one

@derailed derailed added the question Further information is requested label Nov 21, 2023
@derailed
Copy link
Owner

@olfway Jayson is correct and this behavior I think has been present for a while...
There is a related PR that would further enforce deletion aka idiotLight feature.
Once this merges we could relax this a bit as there will be an additional safeguard.

@derailed derailed added the enhancement New feature or request label Nov 21, 2023
@olfway
Copy link

olfway commented Nov 22, 2023

If you mean this #2248, I hope it will be configurable

@derailed
Copy link
Owner

Right! idiotLight would your option...

derailed added a commit that referenced this issue Dec 7, 2023
@derailed
Fix #2297: Enable multi select on nodes
fe7c970
@derailed derailed mentioned this issue Dec 7, 2023
Merged
derailed added a commit that referenced this issue Dec 7, 2023
@derailed
K9s Release v0.29.0 (#2326)
a44cb61 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix #2290 - Add freebsd assets

* Maintenance cleaning up

* Fix #2166 - Add taint tracking column to node view

* Fix #2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix #1513: Change log default to tail vs last 5min

* Fix #2166: Add taint indicator on node view

* Fix #2165: Track init co restarts

* Fix #2308: Fix rbac auth checks

* Fix #2036: Fix npe on filtering CRDs

* Fix #2219: Turn on TTY option on shellpod

* Fix #2167: Update color escape sequence on copy

* Fix #2297: Enable multi select on nodes

* Cleanup headers

* Fix #2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix #2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this issue Feb 23, 2024
@derailed @thejoeejoee
K9s Release v0.29.0 (derailed#2326)
490c1ee 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix derailed#2290 - Add freebsd assets

* Maintenance cleaning up

* Fix derailed#2166 - Add taint tracking column to node view

* Fix derailed#2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix derailed#1513: Change log default to tail vs last 5min

* Fix derailed#2166: Add taint indicator on node view

* Fix derailed#2165: Track init co restarts

* Fix derailed#2308: Fix rbac auth checks

* Fix derailed#2036: Fix npe on filtering CRDs

* Fix derailed#2219: Turn on TTY option on shellpod

* Fix derailed#2167: Update color escape sequence on copy

* Fix derailed#2297: Enable multi select on nodes

* Cleanup headers

* Fix derailed#2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix derailed#2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
@derailed
K9s Release v0.29.0 (derailed#2326)
d5f443b 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix derailed#2290 - Add freebsd assets

* Maintenance cleaning up

* Fix derailed#2166 - Add taint tracking column to node view

* Fix derailed#2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix derailed#1513: Change log default to tail vs last 5min

* Fix derailed#2166: Add taint indicator on node view

* Fix derailed#2165: Track init co restarts

* Fix derailed#2308: Fix rbac auth checks

* Fix derailed#2036: Fix npe on filtering CRDs

* Fix derailed#2219: Turn on TTY option on shellpod

* Fix derailed#2167: Update color escape sequence on copy

* Fix derailed#2297: Enable multi select on nodes

* Cleanup headers

* Fix derailed#2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix derailed#2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@derailed @olfway @wjiec @WZHGAHO