Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFocusable is too strict on tabindex #4632

Closed
WilcoFiers opened this issue Nov 6, 2024 · 2 comments · Fixed by #4637
Closed

isFocusable is too strict on tabindex #4632

WilcoFiers opened this issue Nov 6, 2024 · 2 comments · Fixed by #4637
Labels
core Issues in the core code (lib/core) fix Bug fixes good first issue For first-time contributors

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Nov 6, 2024 •
edited
Loading

The way axe-core checks whether tabindex is valid is by calling parseInt(). That's different from how HTMLhttps://html.spec.whatwg.org/#rules-for-parsing-integers says to do it. Basically, axe should use this to match, and then parseInt the captured group: /^\s*([-+]?\d+)/

The issue is here: lib/commons/dom/is-focusable.js
The tests for it need to be here: test/commons/dom/is-focusable.js
@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) fix Bug fixes good first issue For first-time contributors labels Nov 6, 2024
@ahmedhalac
Copy link
Contributor

Hi @WilcoFiers. Can I work on this?

@WilcoFiers
Copy link
Contributor Author

@ahmedhalac, yeah that would be great!

ahmedhalac added a commit to ahmedhalac/axe-core that referenced this issue Nov 11, 2024
@ahmedhalac
refactor(dequelabs#4632): correct tabindex parsing logic
84bb7d2 
Ensures tabindex is correctly parsed as an integer using regex instead of parseInt to comply with HTML standards.

Related to dequelabs#4632
@ahmedhalac ahmedhalac mentioned this issue Nov 11, 2024
Merged
ahmedhalac added a commit to ahmedhalac/axe-core that referenced this issue Nov 13, 2024
@ahmedhalac
Merge branch 'develop' into refactor/dequelabs#4632-tabindex-regex-parse
da09e6b
ahmedhalac added a commit to ahmedhalac/axe-core that referenced this issue Nov 13, 2024
@ahmedhalac
feat(dequelabs#4632): add parseTabindex reusable method
fcf7899 
Add parseTabindex method in lib/core/utils and reused it in multiple places across the codebase

Related to dequelabs#4632
ahmedhalac added a commit to ahmedhalac/axe-core that referenced this issue Nov 19, 2024
@ahmedhalac
Merge branch 'develop' into refactor/dequelabs#4632-tabindex-regex-parse
77f88ae
ahmedhalac added a commit to ahmedhalac/axe-core that referenced this issue Nov 19, 2024
@ahmedhalac
fix(dequelabs#4632): Fixed tabindex condition
91210e9 
Related to dequelabs#4632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core) fix Bug fixes good first issue For first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: consistently parse tabindex, following HTML 5 spec ahmedhalac/axe-core
2 participants
@WilcoFiers @ahmedhalac