Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-F needs to be smarter #6

Open
wh5a opened this issue Jan 26, 2010 · 2 comments
Open

Ctrl-F needs to be smarter #6

wh5a opened this issue Jan 26, 2010 · 2 comments

Comments

@wh5a
Copy link

wh5a commented Jan 26, 2010

Emacs' Ctrl-F keybinding is disabled by default, which is good. Unless there really is a horizontal scroll bar. The problem is that we lose the find text functionality. Can we stop overriding Ctrl-F when we scroll to the right end?

@decklin
Copy link
Owner

decklin commented Jan 26, 2010

It should do that already, but it's buggy on some pages. The test is

if (window.innerWidth + window.scrollX - 15 < document.width)

15 is the difference I got between window.innerWidth + window.scrollX and document.width when I tried opening a bunch of pages and scrolling all the way to the right (I also took a screenshot and measured the scrollbar; same thing). It should not be hard coded (it's probably wrong on other platforms) but I don't know how to properly get the real value.

@decklin
Copy link
Owner

decklin commented Jan 26, 2010

I think if I removed the scrollbar kludge (the 15 pixels) it would probably work better. I'm going to try running with that for a while. It will prevent you from scrolling completely to the right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants