Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use secrets as environment variables #186

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

worldtiki
Copy link

@worldtiki worldtiki commented Oct 18, 2024

Description

In order to improve the security posture of druid installations using helm chart, I propose this change where environment variables can be set using kubernetes secrets.
This would be useful, for example, when configuring a Postgres extension where one needs to provide credentials.

Example of usage:

envFromSecrets:
  - name: "DATABASE_USER"
    secretKeyRefKey: "databaseSecrets"
    secretKeyRefName: "username"
  - name: "DATABASE_PASSWORD"
    secretKeyRefKey: "databaseSecrets"
    secretKeyRefName: "password"

I'm opening as a draft to get initial feedback. If you agree with the proposal I'll polish the code and update the docs.


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant