New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL: should not show bar chart comparing very different SVs #2938

Open

pradh opened this issue Jul 13, 2023 · 0 comments

Labels

nl

Contributor

pradh commented Jul 13, 2023

[Most profitable sources of energy production in Texas last year]

pradh added the nl label

pradh mentioned this issue

NL: fix a few bugs #2945

Merged

pradh added a commit that referenced this issue


          NL: fix a few bugs (#2945)

bddec6f

1. Bug in extend_svs where we don't always check SV compatibility caused
#2938

<img width="400" alt="Screenshot 2023-07-13 at 7 54 21 PM"
src="https://github.com/datacommonsorg/website/assets/4375037/7ffd67c0-ca2e-4a60-b61d-7cd71be08511">

3. Fix #2932 by limiting
the number of extended SVs we plot in a bar chart to 16, and also keep
the "main SV" pinned as the first entry so its clear.

<img width="400" alt="Screenshot 2023-07-13 at 7 52 53 PM"
src="https://github.com/datacommonsorg/website/assets/4375037/017defe3-2759-46af-8e92-6f3c373aa61c">

5. Fix #2925 by ensuring
that contained-in doesn't match substrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment