Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL: Consider dropping per-capita charts in lieu of chart controls #2917

Open
pradh opened this issue Jul 11, 2023 · 0 comments
Open

NL: Consider dropping per-capita charts in lieu of chart controls #2917

pradh opened this issue Jul 11, 2023 · 0 comments
Labels
nl Issues dealing with the Data Commons NL interface

Comments

@pradh
Copy link
Contributor

pradh commented Jul 11, 2023

No description provided.

@pradh pradh added the nl Issues dealing with the Data Commons NL interface label Jul 11, 2023
@pradh pradh changed the title NL: In medium index, drop more per-capita cases NL: Consider dropping per-capita charts in lieu of chart controls Jul 11, 2023
@pradh pradh mentioned this issue Jul 12, 2023
Merged
pradh added a commit that referenced this issue Jul 12, 2023
@pradh
NL: misc fulfillment fixes (#2923)
72d91fe 
#### 1 - Handle mixed fallbacks better

If we retrieve a place or variable from context and also do place
fallback, provide a unified message.

Before this PR we would not report place fallback when we fallback from
a place in context. [asthma in california] -> [what about blood
pressure?]

Now we'll say, `Tried looking up relevant statistics for "California"
based on your prior queries, but found no results. Here are results for
"United States" instead.`

#### 2 - Avoid duplicate SVs in comparison bar charts

[How long do workers in Maryland live] from earlier today

#### 3 - Avoid bar charts that have no SV in title


![image](https://github.com/datacommonsorg/website/assets/4375037/243a5c3a-2777-48e5-962d-2f829b0a2607)

These come about because we were expanding a "main SV" even when it
doesn't pass existing check, so fix that.

#### 4 - Add fallback info debug page


![image](https://github.com/datacommonsorg/website/assets/4375037/aa8e48ff-49f3-4582-9c75-68b3acb2412c)

#### 5 - Exclude more per-capita SVs

This is a temporary thing until we have [chart controls for
per-capita](#2917).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nl Issues dealing with the Data Commons NL interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pradh