Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying wikitext is not enough for files storing all metadata in SDC #207

Open
jarek-tuszynski opened this issue Jun 21, 2024 · 3 comments

Comments

@jarek-tuszynski
Copy link

I was just fixing File:IAPH-Paisaje_cultural_de_Montoro-PHOTO-2024-05-07-12-38-45_(cropped).jpg where page created by CropTool was missing a license and had some Lua Errors. The issue was that the source file was storing license data in SDC and was using {{license from structured data}} template to create license info. CropTool copied the wikitext but not SDC data leaving the crop file without metadata. CropTool should be copying some or all SDC metadata from source file. If any help is needed on Commons please let me know by pinging "Jarekt"

@danmichaelo
Copy link
Owner

@jarek-tuszynski Right, I'm not really familiar with SDC at all. Seems like there are many fields that should not be copied over (width, height, size, checksum, etc.). Would you recommend creating an include list of properties to copy over (license, etc.) or an exclude list or something smarter?

@don-vip
Copy link

don-vip commented Aug 24, 2024

I guess an exclude list would be fine. I think about this one:

  • P2048 (height)
  • P2049 (width)
  • P3575 (data size)
  • P4092 (checksum)
  • P9310 (pHash checksum)

@lubianat
Copy link

Hi!

I opened a small discussion on the Talk page on this exact topic:

https://commons.wikimedia.org/wiki/Commons_talk:CropTool#Structured_Data

I think P18 (depicts) is significant enough to warrant some kind of check (or at least a note/warning), because it will not be the case some times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants