Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Issue: book page crops are not book themselves #198

Open
irodriguez-moreno opened this issue Apr 2, 2024 · 2 comments
Open

Comments

@irodriguez-moreno
Copy link

irodriguez-moreno commented Apr 2, 2024

Page crops are not books themselves, but when Croptool makes a description page for a crop, it uses the same {{Book}} template. Most users (myself included) don't ever bother to change it, and so there are thousands and thousands of wrongly tagged files, populating thousands of categories.

Instead, I propose the following:

  1. Change {{tl|Book}} for {{tl|Artwork}} when cropping from books.
  2. Remove the |Wikidata= parameter, as 100% of the time the Wikidata entity refers to the edition of the book, and not the cropped artwork.
  3. Remove Book and PDF/DJVU categories.
@danmichaelo
Copy link
Owner

danmichaelo commented Jul 29, 2024

@irodriguez-moreno Hm, replacing {{tl|Book}} with {{tl|Artwork}} seems a bit dangerous, but I can configure it to remove {{tl|Book}}. Let me know if you think that's not a good idea!

As for 3, there is a list of category patterns that should not be copied over. I've added "DjVu files" and "PDF files" to it now. Let me know if there are more patterns you want added to the list (but preferably a bit more specific than "Book").

@irodriguez-moreno
Copy link
Author

Hi! I am so sorry for taking so long to answer.
I tried Croptool now, and it seems to be a little bit off (see this diff). Its not that big of a deal if it seems dangerous. In the long run we probably need a more specialized tool for dealing with book graphic elements.

As for the categories patterns I would add:
^Books (?:by|from|published)
books from \w+$ its another pattern (1890 books from Spain and so on)
^Uploaded with these files are actually not uploaded using that tools as they are uploaded using CropTool, so it makes sense we remove those categories.
Also the spelling of "DjVu files" varies a lot from what I am seeing. At least DjVu, DJVU and djvu are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants