Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Paper Comments Show when Created not when Committed on the Timeline #227

Open
danielBingham opened this issue Oct 22, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@danielBingham
Copy link
Owner

Describe the bug

Describe the bug you encountered. What happened? What did you expect to happen?

Paper comemnts will show up on the timeline when they were created, not when they were committed. This is due to the event_date being set at creation, not when the status is changed to committed. However, because of the way we're polling for and appending events, if we fix the issues by simply updating the event_date at the time of the status change, we'll end up with duplicate events on the timeline. A comment will show in the timeline when it was created and when it was committed.

We need a way to filter out events from the timeline that have been updated.

To Reproduce

Please describe the exact steps required to reproduce the bug.

  1. Create a comment by focusing on the comment text area. (You can confirm the comment is created because the visibility will be whatever the journal/submission/preprint would set, rather than none.)
  2. Do anything that will create a timeline event entry.
    1. Create a review and submit it so that it shows on the timeline.
    2. OR change the status of the submission so that the status change shows on the timeline.
    3. Etc
  3. Submit the commit. Confirm the comment shows before the events you created after you created the comment.
@danielBingham danielBingham added the bug Something isn't working label Oct 22, 2023
@danielBingham danielBingham added this to the 0.4.0 milestone Oct 22, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Peer Review Oct 22, 2023
@danielBingham danielBingham moved this from Backlog to In Progress in Peer Review Nov 1, 2023
@danielBingham danielBingham moved this from In Progress to Done in Peer Review Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant