Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Journal Paging is Wrong #225

Open
danielBingham opened this issue Oct 20, 2023 · 0 comments
Open

[BUG] Journal Paging is Wrong #225

danielBingham opened this issue Oct 20, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
0.4.0

Comments

@danielBingham
Copy link
Owner

Describe the bug

Describe the bug you encountered. What happened? What did you expect to happen?

Journal paging doesn't account for rows from the joins, which means pages have fewer results than they should. This can cause weird bugs.

To Reproduce

Please describe the exact steps required to reproduce the bug.

  1. Create more than 8 journals.
  2. Confirm the 8th journal doesn't appear on the journal list.
@danielBingham danielBingham added the bug Something isn't working label Oct 20, 2023
@danielBingham danielBingham added this to the 0.4.0 milestone Oct 20, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Peer Review Oct 20, 2023
@danielBingham danielBingham moved this from Backlog to In Progress in Peer Review Oct 31, 2023
@danielBingham danielBingham moved this from In Progress to Done in Peer Review Oct 31, 2023
danielBingham added a commit that referenced this issue Nov 1, 2023
@danielBingham
Issue #225 - Fixing journal paging.
fdd0d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Peer Review
Status: Done
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@danielBingham