Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: unable to close GenericReferralModal on mobile size #1608

Closed
1 task done
sshanzel opened this issue Nov 20, 2024 · 0 comments · Fixed by dailydotdev/apps#3876
Closed
1 task done

🐛 BUG: unable to close GenericReferralModal on mobile size #1608

sshanzel opened this issue Nov 20, 2024 · 0 comments · Fixed by dailydotdev/apps#3876
Labels
help wanted Status: Accepted Status: Available Type: Bug

Comments

@sshanzel
Copy link
Member

What went wrong? 🤔

The generic referral modal is not closeable on mobile.

Expected Behavior

Should allow the user to close it.

Steps to Reproduce Issue

A bit difficult to reproduce, but on dev environment, there should be a `BootPopups` component with a useEffect that manages the popup's state.

Solution Proposed

Either add a close button, or probably better if we add isDrawerOnMobile as true on the Modal component itself.

Screenshots

No response

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Status: Accepted Status: Available Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unable to close GenericReferralModal on mobile size Abhi-Bohora/apps
1 participant
@sshanzel